Skip to content

Commit

Permalink
[SC-160] Add contribution guidelines (#4)
Browse files Browse the repository at this point in the history
* feat: add readme

* feat: add architecture diagram

* feat: minor readme changes

* feat: improve the diagram

* feat: update diagram

* feat: add contribution guidelines

* fix: fix a typo

* feat: change review requirements
  • Loading branch information
barrutko authored Oct 3, 2023
1 parent 3d7b168 commit a014330
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,12 @@ Forwarders are contracts on the host domain, where the governance of the protoco
Executors serve as admins of the bridged domain instances of the protocol. <br>They are responsible for storying the queue of proposals passed from the host domain governance and their execution. <br> They manage bridged domain protocol instance using standard payload pattern.
## ✍️ Architecture Diagram
![Architecture Diagram](/diagram.png)
## 🤝 Contribution Guidelines
In order to add governance relay infrastructure for a new domain, perform the following steps:
1. Go to [XChain Helpers](https://github.com/marsfoundation/xchain-helpers) repository and add a proper domain helper abstracting away the process of passing messages between host domain and your bridged domain.
2. Add proper `CrosschainForwarder` to the `/src/forwarders` directory and proper `BridgeExecutor` to the `/src/executors` directory. Follow currently used naming convention.
3. If there are any dependencies required, copy them into `/src/dependencies/<YOUR_DOMAIN_NAME>` directory.
4. Add a new test file for your domain to the `/test` directory. Inherit `CrosschainTestBase` and add tests specific to your domain to the test suite. All of the tests have to pass. Follow linting and naming convention used in other test files.
5. Use proper labeling for your open PR (always set adequate priority and status)
6. Get an approving review from at least one of three designated reviewers - **@hexonaut**, **@lucas-manuel** or **@barrutko**
7. Enjoy governance messages being passed through the bridge to your domain! 🎉

0 comments on commit a014330

Please sign in to comment.