Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make built-in theme customization easy through CSS variables #209

Closed
3 tasks done
yhatt opened this issue Feb 4, 2021 · 3 comments · Fixed by #264
Closed
3 tasks done

Make built-in theme customization easy through CSS variables #209

yhatt opened this issue Feb 4, 2021 · 3 comments · Fixed by #264
Labels
enhancement New feature or request

Comments

@yhatt
Copy link
Member

yhatt commented Feb 4, 2021

Continue from marp-team/marp#48. Marp built-in themes are made by Sass and some themes are using mixin-based color scheme definition.
https://github.com/marp-team/marp-core/tree/master/themes

However it makes difficult to change theme color through tweaking style by <style> because some color schemes are defined as Sass variables. Some users are confusing to the fact that still require Sass compiler just for customize colors (marp-team/marp#73).

So must be better to move into using CSS variables. The legacy browser that has not supported CSS variables is already no longer required to consider.

⚠️ This migration may make broken the look of exist Marp slides so this change must be the major update.

ToDo

  • Default theme (v3)
  • Gaia theme (v2.0.0)
  • Uncover theme (v2.0.0)
@yhatt
Copy link
Member Author

yhatt commented Apr 24, 2021

Marp Core v2.0.0 has supported setting color scheme through CSS variables, in Gaia theme and Uncover theme. See #221 for detail.

⚠️ Default theme is not yet ready to customize color scheme through CSS variables. It is depending on github-markdown-css and not provided variables-based color definition as like as GitHub's dark mode. Current invert class has many unique definitions against the current GitHub dark mode so it seems wise to wait for the support of variables used by GitHub.

@yhatt yhatt added the upstream Caused in upstream, not in this repo label Apr 24, 2021
@vedranmiletic

This comment has been minimized.

@yhatt

This comment has been minimized.

@yhatt yhatt linked a pull request Oct 30, 2021 that will close this issue
@yhatt yhatt removed the upstream Caused in upstream, not in this repo label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants