We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-admin 2.6.0
It seems that the Props types of Datagrid has a mistake.
Datagrid.propTypes = { ... currentSort: PropTypes.shape({ sort: PropTypes.string, order: PropTypes.string, }).isRequired, ... }
However if I log this.props, I have currentSort: {field: "id", order: "DESC"}. See how it contains field and not sort.
this.props
In some resources I also get a warning: Warning: Failed prop type: The prop currentSortis marked as required inDatagrid, but its value is undefined.
Warning: Failed prop type: The prop
is marked as required in
, but its value is undefined.
I suggest a PR with :
Datagrid.propTypes = { ... currentSort: PropTypes.shape({ field: PropTypes.string, order: PropTypes.string, }).isRequired, ... } ... Datagrid.defaultProps = { currentSort: {}, };
The text was updated successfully, but these errors were encountered:
Thanks for reporting! Can you make a PR fixing the proptypes names, removing the isRequired on it but leaving the default as it is?
isRequired
Sorry, something went wrong.
rdy. Closing
No branches or pull requests
react-admin 2.6.0
It seems that the Props types of Datagrid has a mistake.
However if I log
this.props
, I have currentSort: {field: "id", order: "DESC"}. See how it contains field and not sort.In some resources I also get a warning:
Warning: Failed prop type: The prop
currentSortis marked as required in
Datagrid, but its value is undefined.
I suggest a PR with :
The text was updated successfully, but these errors were encountered: