Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export button should not show up on empty List page #2483

Closed
fzaninotto opened this issue Oct 29, 2018 · 2 comments
Closed

Export button should not show up on empty List page #2483

fzaninotto opened this issue Oct 29, 2018 · 2 comments

Comments

@fzaninotto
Copy link
Member

fzaninotto commented Oct 29, 2018

When new users discover a react-admin app, and they have no data yet, the list screen is intimidating. It shows a "no results found" and an export button...

image

  • If there is no result, the export button should not appear - or should appear greyed out
@fzaninotto fzaninotto changed the title Export button should not show up on empty page Export button should not show up on empty List page Oct 29, 2018
@afilp
Copy link
Contributor

afilp commented Nov 5, 2018

@fzaninotto Regarding the default "EXPORT" functionality, in most cases we do not need this, as it would require us to do major work on custom "exporter" functions, while the client does not need an export at all.

Instead of us having to create our own actions component, could we just use exporter = {false} in order to disable the "EXPORT" functionality? (not show it at all).

The above proposal is exactly similar to what we do with bulkActions={false}.

@afilp
Copy link
Contributor

afilp commented Dec 10, 2018

Concerning my latest comment above, I have created a PR for your evaluation.

I already use this option in my projects (i.e. hiding the export button in certain Lists) and I have the feeling that others may need it too. It is up to you to decide. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants