q-dev: Fix detecting already assigned devices on setting apply

Device with specific device_id doesn't equal device with wildcard
device_id, so `dev in old_devs` check cannot be used.
Fix this by using DeviceAssignment.matches method. A side effect is
getting old assignment earlier.

QubesOS/qubes-issues#9325

Author: marmarek

qubesmanager/settings.py

@@ -1268,8 +1268,10 @@ def __apply_devices_tab__(self):
                         for i in range(self.dev_list.selected_list.count())]
 
             for dev in new_devs:
-                if dev not in old_devs:
-                    options = {}
+                old_assignments[0] = [old for old in old_devs
+                                      if old.matches(dev)]
+                if not old_assignments:
+                    options = old_assignments[0].options.clone()
                     if dev.port_id in self.new_strict_reset_list:
                         options['no-strict-reset'] = True
                     ass = device_protocol.DeviceAssignment.new(
@@ -1282,18 +1284,7 @@ def __apply_devices_tab__(self):
                     self.vm.devices['pci'].assign(ass)
                 elif (dev.port_id in self.current_strict_reset_list) != \
                         (dev.port_id in self.new_strict_reset_list):
-                    current_assignment = None
-                    for assignment in self.vm.devices[
-                            'pci'].get_assigned_devices(required_only=True):
-                        if assignment.port_id == dev.port_id:
-                            current_assignment = assignment
-                            break
-                    if current_assignment is None:
-                        # it would be very weird if this happened
-                        msg.append(self.tr("Error re-assigning device ") +
-                                   dev.port_id)
-                        continue
-
+                    current_assignment = old_assignments[0]
                     self.vm.devices['pci'].unassign(current_assignment)
 
                     current_assignment.options['no-strict-reset'] = \