-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: batch evaluate exclude not found #518
Feature: batch evaluate exclude not found #518
Conversation
@markphelps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea @itaischwartz ! Thanks for the contribution. Just one minor request re: tests.
I agree maybe a new API method is needed to add an error to each evaluation request/response.
server/evaluator_test.go
Outdated
|
||
resp, err := s.BatchEvaluate(context.TODO(), &flipt.BatchEvaluationRequest{ | ||
RequestId: "12345", | ||
ExcludeNotFound: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind adding another test where ExcludeNotFound
is false or simply not set (so it defaults to false)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that TestEvaluate_FlagNotFound
is testing this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that it's testing another grpc call.
I'll add the missing test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@all-contributors please add @itaischwartz for code |
I've put up a pull request to add @itaischwartz! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks again!
Add an option to exclude not-found flags from batch evaluate calls.
This change makes it possible to separate flags management from client calls.