Updating Issue #578: Update the deletion message #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing the double confirmation dialog and updating the deletion message that is displayed to the user to make it clearer to what they are deleting.
aebadirad
approved these changes
Apr 24, 2018
aebadirad
added a commit
that referenced
this pull request
Apr 24, 2018
* DHFPROD-496 fix QuickStart naming in app “QuickStart”, not “Quick Start” * DHFPROD-497 fix property index selection Add flags to property to keep track of what indexes are set (instead of using name). Set flags based on entity state when editor opens. Set entity state based on flags on save. * Fixes #582 - should be reviewed for UX before merging. (#906) * Fix tab bar layout issue #798 (#909) * Rework of fix for issue #557 where URI in request to /doc API (#915) Now matches other implementations throughout codebase which leverage encodeURIComponent() * Fixing Issue #578: Adding deletion dialog (#889) (#917) Adding an additional dialog message to the 2.0 development branch that will require the user to press yes twice before the entity and all associated flows and code are deleted * DHFPROD-664 adjust offset, size of new entities in UI (#918) * Updating Issue #578: Update the deletion message (#919) Removing the double confirmation dialog and updating the deletion message that is displayed to the user to make it clearer to what they are deleting.
|
@mhuang-ml can you also give a push of this to 2.x-develop as well so both versions stay in sync? |
|
@aebadirad, sure thing, I'll create the PR for the 2.x-develop branch tonight. |
|
@mhuang-ml can you push this to 3.x-develop as well? |
|
@ayuwono, I just created the PR to synchronize this change with 3.x-develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the double confirmation dialog and updating the
deletion message that is displayed to the user to make it
clearer to what they are deleting.
@aebadirad, this incorporates the latest feedback by @wooldridge and @ayuwono