Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHFPROD-466 Improving tests for quickstart host config #875

Merged
merged 9 commits into from
Apr 11, 2018
Merged

DHFPROD-466 Improving tests for quickstart host config #875

merged 9 commits into from
Apr 11, 2018

Conversation

grechaw
Copy link

@grechaw grechaw commented Apr 9, 2018

This PR, again, delivers some big changes to unit tests.
It has a small issue, again something with setup and teardown, where tracing counts fail for certain legacy flows.

When I run the tests with develop, then run the e2e tests on this branch, they all pass. mysterious what prevents tracing from working on these handful of tests.

also there's a init() test which fails once during a whole run, then passes. This looks like an innocuous issue.

I'd like a good analysis from @srinath as first priority, as getting this right is blocking my other fixes for the sprint.

@grechaw grechaw requested a review from aebadirad April 9, 2018 14:37
@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/327/testReport
70 tests run, 0 skipped, 19 failed.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/329/testReport
70 tests run, 0 skipped, 19 failed.

@grechaw
Copy link
Author

grechaw commented Apr 9, 2018

The latest push should give us complete e2e clean tests.
I've divided the tests into a few suites and configured gradle to exclude running individual tests in subfolders.
This has enabled me to do a grand setup and teardown for most of the tests, while retaining independence for the e2e tests which were getting some interference.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/332/testReport
599 tests run, 0 skipped, 10 failed.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/334/testReport
599 tests run, 0 skipped, 9 failed.

@srinathgit
Copy link
Contributor

Charles,

  1. Failure in JobManagerTest:
    When tracing is enabled, we set the state in server field cache and read from it when isEnabled() is called. So essentially, tracing is set on only on the node where it is called and not on the entire cluster.
    What happens in those failed tests is that when the flow is run, the request to collector goes to one node where cache is not set and hence the trace document is not created.
    The request to run the flow goes to the node where the cache is set and hence those documents are created. I have create a PR in your repository where I have made few changes.
    https://github.com/grechaw/marklogic-data-hub/pull/1

2 . StreamCollectorTest is supposed to run with specific heap settings
task collectorTest(type: Test, dependsOn: testClasses) {
include '**/StreamCollector*'
minHeapSize = "128m"
maxHeapSize = "256m"
}
By adding it to CoreTestSuite, will these settings be honoured ?

  1. com.marklogic.quickstart.service.FlowManagerServiceTest.runMlcp fails sometimes if the classpath is too long. I have seen this issue in my local machine, but I don't know if the same issue
    is hit in jenkins as well
    https://stackoverflow.com/questions/10519558/createprocess-error-206-the-filename-or-extension-is-too-long-when-running-main

@grechaw
Copy link
Author

grechaw commented Apr 10, 2018

Thanks Srinath. I can make marklogic/datahub-central#1519 work this way, I was curious about it.

not sure what to do about marklogic/datahub-central#1518 but maybe we can revisit it. I recommend ditching eclipse. I recommend that every time it comes up. IDEA is better.

@grechaw
Copy link
Author

grechaw commented Apr 10, 2018

So there are two solutions for number 2. We can separate stream collector, as you have, and provide a separate hub install/uninstall, or we could run the whole suite with the memory constraints you need for stream collector test.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/337/testReport
599 tests run, 0 skipped, 1 failed.

@grechaw
Copy link
Author

grechaw commented Apr 10, 2018

Well that single failure is the mlcp one. Can we merge this and take up the classpath length as a separate issue?

@srinathgit
Copy link
Contributor

I think we can do that. I am not sure if the failure in jenkins is also due to classpath length. I have only seen that (classpath length issue) in my local machine.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/340/testReport
599 tests run, 0 skipped, 1 failed.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/342/testReport
599 tests run, 0 skipped, 2 failed.

@grechaw
Copy link
Author

grechaw commented Apr 11, 2018

I've committed something that might help the mlcp classpath issue. I see what the problem is, and have tried just shrinking the runtime classpath to be smaller for the mlcp call.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/344/testReport
599 tests run, 0 skipped, 1 failed.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/346/testReport
599 tests run, 0 skipped, 1 failed.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/349/testReport
599 tests run, 0 skipped, 1 failed.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/350/testReport
No test results found.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/352/testReport
5 tests run, 0 skipped, 5 failed.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/353/testReport
No test results found.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/DHF_b9_nightly_linux_cluster/354/testReport
599 tests run, 0 skipped, 1 failed.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/dhf-core-develop-rh7cluster-PR%22S/355/testReport
No test results found.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/dhf-core-develop-rh7cluster-PR%22S/357/testReport
No test results found.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/dhf-core-develop-rh7cluster-PR%22S/359/testReport
No test results found.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/dhf-core-develop-rh7cluster-PR%22S/361/testReport
No test results found.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/dhf-core-develop-rh7cluster-PR%22S/363/testReport
No test results found.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/dhf-core-develop-rh7cluster-PR%22S/365/testReport
No test results found.

@aebadirad aebadirad merged commit a746b8d into Marklogic-retired:develop Apr 11, 2018
@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/dhf-core-develop-rh7cluster-PR/366/testReport
599 tests run, 0 skipped, 1 failed.

@grechaw grechaw deleted the assume-installed branch April 25, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants