Fixing hard-coding of admin/admin in project setup #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also comments out some code that @srinath had committed in order to set up SSL testing. We may want to talk over that before merge. |
|
Jenkins Build failure |
aebadirad
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple of things in the build.
It fixes an issue with SLF4J bindings by including a bridge jar between slf4j and log4j, upon which mlcp depends.
Secondly it gets rid of a little nefarious hard-coding in test setup that confused the heck out of me for a while. Now the values in gradle.properties are used for mlUsername and mlPassword rather than code slapping them onto some generated ones. I think this is an improvement but would like confirmation.
I found that some setup code relied on the value in gradle.properties regardless of the hard-coded bit in project creation. This approach gets rid of one code path, but not the last.