-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/java doc updates #803
Conversation
… since it's in the interface that gets implemented by the impl class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing that guidance -- a lot of work.
Are there plans to add JavaDoc at the interface level in the future?
Jenkins Build failure |
Yes, denoting what data hub operations are logically encapsulated in the interface offering. |
List<Flow> getLocalFlowsForEntity(String entityName, FlowType flowType); | ||
|
||
/** | ||
* Obtains a flow form a property file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
form => from
String serialize(); | ||
|
||
/** | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creates a Properties object representing the flow
FlowRunner withSourceClient(DatabaseClient sourceClient); | ||
|
||
/** | ||
* Sets which database the flow will output to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sets the database where flow output data will be persisted
FlowRunner withThreadCount(int threadCount); | ||
|
||
/** | ||
* Sets the source client on the flow runner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sets the source client on the flow runner. The source client determines which database to run against for building the envelope.
FlowRunner withDestinationDatabase(String destinationDatabase); | ||
|
||
/** | ||
* Sets the options for the flowRunner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sets the options to be passed into the xqy or sjs flow in the $options or options variables of main.
* @param first - the minimum required string path to get the absolute path from | ||
* @param more - additional paths submitted | ||
* @return the absolute path of each string path provided | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method is only used by the test project. can it be moved out of here?
* @param flowName - the name of the flow | ||
* @param flowType - FlowType (sjs or xqy) | ||
* @return the directory path as a Path type | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look at where this bad boy is being used. Mostly for internal and testing. Only 1 instance in quickstart that is questionable, at best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to leave this in due to quickstart until we can figure out a better way to support the quickstart use without invoking a direct implementation.
* Returns the disk path of the entity | ||
* @param entityName - name of the entity as string | ||
* @return Path of the entity | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only used in tests. maybe move out of public interface..
Jenkins Build failure |
Jenkins Build failure |
Java doccing done to our public interface APIs