Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/java doc updates #803

Merged
merged 20 commits into from
Mar 16, 2018
Merged

Feature/java doc updates #803

merged 20 commits into from
Mar 16, 2018

Conversation

aebadirad
Copy link
Contributor

Java doccing done to our public interface APIs

Copy link

@ehennum ehennum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing that guidance -- a lot of work.

Are there plans to add JavaDoc at the interface level in the future?

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/Labs/job/DHF_b9_nightly_linux_cluster/194/testReport
481 tests run, 0 skipped, 3 failed.

@aebadirad
Copy link
Contributor Author

Yes, denoting what data hub operations are logically encapsulated in the interface offering.

@aebadirad aebadirad self-assigned this Mar 14, 2018
List<Flow> getLocalFlowsForEntity(String entityName, FlowType flowType);

/**
* Obtains a flow form a property file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

form => from

String serialize();

/**
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creates a Properties object representing the flow

FlowRunner withSourceClient(DatabaseClient sourceClient);

/**
* Sets which database the flow will output to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sets the database where flow output data will be persisted

FlowRunner withThreadCount(int threadCount);

/**
* Sets the source client on the flow runner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sets the source client on the flow runner. The source client determines which database to run against for building the envelope.

FlowRunner withDestinationDatabase(String destinationDatabase);

/**
* Sets the options for the flowRunner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sets the options to be passed into the xqy or sjs flow in the $options or options variables of main.

* @param first - the minimum required string path to get the absolute path from
* @param more - additional paths submitted
* @return the absolute path of each string path provided
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method is only used by the test project. can it be moved out of here?

* @param flowName - the name of the flow
* @param flowType - FlowType (sjs or xqy)
* @return the directory path as a Path type
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at where this bad boy is being used. Mostly for internal and testing. Only 1 instance in quickstart that is questionable, at best.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to leave this in due to quickstart until we can figure out a better way to support the quickstart use without invoking a direct implementation.

* Returns the disk path of the entity
* @param entityName - name of the entity as string
* @return Path of the entity
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only used in tests. maybe move out of public interface..

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/Labs/job/DHF_b9_nightly_linux_cluster/200/testReport
481 tests run, 0 skipped, 2 failed.

@marklogic-builder
Copy link

Jenkins Build failure
https://jenkins.marklogic.com/job/Labs/job/DHF_b9_nightly_linux_cluster/201/testReport
481 tests run, 0 skipped, 2 failed.

@aebadirad aebadirad merged commit 81b61f8 into develop Mar 16, 2018
@aebadirad aebadirad deleted the feature/Java_doc_updates branch April 23, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants