Feature/sjs perf #789
Feature/sjs perf #789
Conversation
| plugins { | ||
| id 'net.saliman.properties' version '1.4.6' | ||
| id 'com.marklogic.ml-data-hub' version '2.0.4' | ||
| // id 'com.marklogic.ml-data-hub' version '2.0.4' |
There was a problem hiding this comment.
should not have checked in.. will fix
| import org.gradle.api.tasks.TaskAction | ||
|
|
||
| import com.marklogic.appdeployer.AppConfig | ||
| class MlcpTask extends JavaExec { |
There was a problem hiding this comment.
isn't this part of ml-gradle? from Rob's wiki I wouldn't think this would be needed (but I'm still learning about gradle)
There was a problem hiding this comment.
he hasn't updated to the latest one yet. I forgot to put a comment in there about it. will do that.
|
|
||
| let inputs = context.inputs | ||
| for (let key in inputs) { | ||
| tracelib.setPluginInput(key, inputs[key]); |
There was a problem hiding this comment.
if (obj.hasOwnProperty(prop)) { needed here?
There was a problem hiding this comment.
nope. that blows up.
There was a problem hiding this comment.
I meant inputs.hasOwnProperty. Only relevant if inputs might inherit properties from somewhere.
There was a problem hiding this comment.
yeah. I fixed it to the right thing and it still blew up.
| } | ||
|
|
||
| let cache = func(); | ||
| //require.call(caller, moduleUri); |
| } | ||
| else { | ||
| const x = new NodeBuilder(); | ||
| return x.toNode(); |
There was a problem hiding this comment.
returning here means the following lines won't be run. Looks like return x.toNode(); should be after the for loop.
There was a problem hiding this comment.
looks like an edge case that would break if it were properly tested. I'll fix that.
| } | ||
| } | ||
| else { | ||
| const x = new NodeBuilder(); |
| traceSteps.push({ | ||
| label: getPluginLabel(currentTrace), | ||
| input: getPluginInput(currentTrace), | ||
| error: rfc.isJson() ? error : error, |
There was a problem hiding this comment.
if pushing the same thing either way, why the test?
| return tracelib.getTrace(id); | ||
| } | ||
|
|
||
| function getTraceIds(q) { |
There was a problem hiding this comment.
is q a query? Either a comment or a better label would be useful
| @@ -187,6 +208,7 @@ private JsonNode validateUserModules() { | |||
| DataHub dataHub = getDataHub(); | |||
| List<DynamicTest> tests = new ArrayList<>(); | |||
|
|
|||
| // flows before a structured change get updated. this ru | |||
There was a problem hiding this comment.
comment missing part of the sentence
There was a problem hiding this comment.
I'm going to remove it because I have no clue what I was typing there.
| FinalCounts finalCounts = new FinalCounts(0, 0, 1, 1, 0, 0, 0, 0, 0, 0, "FAILED"); | ||
| testInputFlowViaMlcp(prefix, "-2", stagingClient, codeFormat, dataFormat, useEs, options, finalCounts); | ||
| })); | ||
| // tests.add(DynamicTest.dynamicTest(flowName + ": " + plugin + " error MLCP", () -> { |
added tests for missing cases
|
Jenkins Build failure |
enjoy!