Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable-host-check to allow external access #773

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

wooldridge
Copy link
Contributor

When installing and running QuickStart on an ML VM, I couldn't access that QuickStart app from my remote machine, i.e. via:

http://engrlab-129-036.engrlab.marklogic.com:4200/

Adding --disable-host-check to the "ng serve" command fixed this:

ng serve -pc proxy.config.json --host 0.0.0.0 --disable-host-check

This is discussed here:

https://stackoverflow.com/questions/43677629/invalid-host-header-when-running-angular-cli-development-server-c9-io

There are reported security implications:

https://medium.com/webpack/webpack-dev-server-middleware-security-issues-1489d950874a

Note that I was not able to solve the issue by adding a --public option (with marklogic.com or *.marklogic.com) instead, which is mentioned in the above article.

@wooldridge wooldridge added the bug label Mar 3, 2018
@wooldridge wooldridge requested a review from aebadirad March 3, 2018 00:25
@marklogic-builder
Copy link

Can one of the admins verify this patch?

@aebadirad
Copy link
Contributor

Since this isn't a production supported feature yet, I'm going to allow this through.

We'll need to discuss having this only happen during development environments in the future if this extends to production use.

@marklogic-builder
Copy link

Can one of the admins verify this patch?

@wooldridge wooldridge merged commit 14ac552 into Marklogic-retired:develop Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants