Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ssl fixup #690

Merged
merged 5 commits into from
Jan 29, 2018
Merged

Feature/ssl fixup #690

merged 5 commits into from
Jan 29, 2018

Conversation

paxtonhare
Copy link
Contributor

enjoy this one!

@paxtonhare
fixed #647
592fd5e 
can now set ssl verifier and hostname
@paxtonhare
fixed #647
ef7ffa5 
can now set ssl verifier and hostname
@paxtonhare
Merge branch 'feature/ssl-fixup' of github.com:marklogic-community/ma…
722d84a 
…rklogic-data-hub into feature/ssl-fixup
@marklogic-builder
Copy link

Can one of the admins verify this patch?

1 similar comment
@marklogic-builder
Copy link

Can one of the admins verify this patch?

aebadirad
aebadirad approved these changes Jan 29, 2018
View reviewed changes
Copy link
Contributor

@aebadirad aebadirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass on windows, looks consistent thorughout with the builder class added

@paxtonhare paxtonhare merged commit 6019b98 into develop Jan 29, 2018
@aebadirad aebadirad deleted the feature/ssl-fixup branch January 31, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aebadirad aebadirad aebadirad approved these changes

@dmcassel dmcassel Awaiting requested review from dmcassel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paxtonhare @marklogic-builder @aebadirad