Fixing Issue #409: add dynamic sizing to facets #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To resolve the issue of long collection names wrapping, then the facet will utilize a different style class so the text is smaller and will appear in a single line. The facet value length will be compared to determine if the custom class will be utilized or not. Added similar logic to the chiclet since the previous chiclets were not being displayed properly, all the UI would show was "Collection:" and you would not be able to see any text. Added hover over tooltip for the chiclet values so that the user can see the full facet name.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
dmcassel
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve the issue of long collection names wrapping, then
the facet will utilize a different style class so the text is
smaller and will appear in a single line. The facet value length
will be compared to determine if the custom class will be utilized
or not.
Added similar logic to the chiclet since the previous chiclets
were not being displayed properly, all the UI would show was
"Collection:" and you would not be able to see any text. Added
hover over tooltip for the chiclet values so that the user can
see the full facet name.