#591 - Show 2.0 features for server versions >= 9 #646
Conversation
This includes "Entities" link in header and "Code Generation" section in Create Flow dialog. Check for version !== 8 rather than == 9.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
wooldridge
changed the title
|
">=9" (ie not 7) |
| @@ -12,7 +12,7 @@ | |||
| <div class="mdl-layout-spacer"></div> | |||
| <nav class="mdl-navigation mdl-layout--large-screen-only"> | |||
| <a id="database-tab" class="mdl-navigation__link" [ngClass]="{'active': isActive('/')}" [routerLink]="['']"><i class="fa fa-dashboard"></i> Dashboard</a> | |||
| <a id="entities-tab" class="mdl-navigation__link" *ngIf="getMarkLogicVersion().startsWith('9')" [ngClass]="{'active': isActive('/entities')}" [routerLink]="['entities']"><i class="fa fa-industry"></i> Entities</a> | |||
| <a id="entities-tab" class="mdl-navigation__link" *ngIf="!getMarkLogicVersion().startsWith('8')" [ngClass]="{'active': isActive('/entities')}" [routerLink]="['entities']"><i class="fa fa-industry"></i> Entities</a> | |||
There was a problem hiding this comment.
I agree with @popzip that we should be >= to 9, not just looking for 'not 8' for completeness of version checking.
There was a problem hiding this comment.
@aebadirad, can you tell me what ML version formats I can expect from the /api/current-project endpoint? I know that value looks like "10.0-20180115" on my local build but I'm not sure how/if it varies with other distributions.
There was a problem hiding this comment.
i think to get the major version you can always get the value before the first period and parse and an integer.
There was a problem hiding this comment.
@aebadirad I addressed the review comments with 05407a3. Can we merge this?
|
Jenkins Build successful |
This includes "Entities" link in header and "Code Generation" section in Create Flow dialog.
Check for version !== 8 rather than == 9.
Fixes marklogic/datahub-central#1130