Issue 503 #645
Merged
Issue 503 #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
aebadirad
suggested changes
Jan 17, 2018
There was a problem hiding this comment.
@RobertSzkutak Can we get an E2E test added to protractor to test to make sure the flow options are being set and a negative "bad flowoptions" test?
|
@aebadirad Could you be more specific about the testing criteria? Thanks! We can touch base offline sometime if you think it would be easier to discuss. |
|
I'm going to pull this in without test, because we do not (and shouldn't) test MLCP and this is a UI pass-through to MLCP |
aebadirad
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows transform_param to become usable and no longer read-only.
Allows you to set a jobId in transform_param.