Fixed #616 #627
Merged
Fixed #616 #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…property when foreaching through it so it doesn't greedily wipe other properties indexes
…ites, plus checking for retaining of index settings after deleting them to verify the bug has been fixed
…ick (angular/protractor#4495) so disabling it so tests can pass
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
dmcassel
approved these changes
Dec 15, 2017
…vel webdriver executeScript command and raw window functions, returning to headless since headed is no longer required
|
I've made the E2E tests for properties more reliable by replacing the coordinate click based system with a lower level implementation that leverages the browser driver and raw window functions to obtain the necessary element to click on, rather than from inside protractor/selenium |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix for marklogic/datahub-central#1117 so that only the selected properties are wiped of their index/pkey/etc settings.
Also included E2E tests for properties and a check for this condition, plus tweaked settings to get the E2E settings to run.