Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHFPROD-1754 + other issues #1792

Merged
merged 5 commits into from
Jan 26, 2019

Conversation

srinathgit
Copy link
Contributor

@srinathgit srinathgit commented Jan 24, 2019

This PR

  1. Removes hardcoded "data-hub-MODULES" and pretty prints the json
  2. Remove 'DeployHubAmpsCommand', its gradle command and tests
  3. Modifies CMASettings to handle nightly
  4. Stops uninstalling of amps
  5. Replace 'mlDeploySecurity' with 'hubDeploySecurity' in tests as amps are scaffolded

@ayuwono
Copy link
Contributor

ayuwono commented Jan 24, 2019

Tested the branch, install is around 2 mins. Uninstall is 1min 30sec. It's going back to normal

@ayuwono
Copy link
Contributor

ayuwono commented Jan 25, 2019

9.0-5 install and uninstall are fine on 4.x fix
install: 2mins
uninstall: 3mins
Srinath's branch: 4.x-develop-amp-uninstall

On windows:
Installation is 2mins 30sec.
Uninstall is 4mins 45sec
Srinath's branch: 4.x-develop-amp-uninstall

@srinathgit
Copy link
Contributor Author

srinathgit commented Jan 25, 2019

@aebadirad ,

The above numbers that Aries has posted are installation and uninstallation times (uninstallation includes removing amps also) from my "4.x-develop-amp-uninstall" branch in a single node machine on mac and windows for ML 9.0-5 . Based on these times, is it ok to include undeploying amps as part of hub uninstallation ?

@aebadirad
Copy link
Contributor

Yeah, this is fine. It's a bit slower, but it does stop leaving amps around.

@aebadirad aebadirad merged commit 04d62cf into Marklogic-retired:4.x-develop Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants