Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHFPROD-1428: Improve the usability of text input elements #1763

Merged
merged 3 commits into from
Jan 22, 2019
Merged

DHFPROD-1428: Improve the usability of text input elements #1763

merged 3 commits into from
Jan 22, 2019

Conversation

brucean52
Copy link
Contributor

No description provided.

@ayuwono
Copy link
Contributor

ayuwono commented Jan 21, 2019

The input flow UI looks fine after the change.

One thing, I'm not sure if it's affected by the change, the pagination marker (on browser, jobs, and trace page) is changed from a circle to an ellipse?

screen shot 2019-01-21 at 2 22 41 pm

@ayuwono
Copy link
Contributor

ayuwono commented Jan 21, 2019

And the results text seems to have multiple lines
screen shot 2019-01-21 at 2 38 04 pm

@aebadirad
Copy link
Contributor

Ooh, let's make sure these haven't changed.

@brucean52
Copy link
Contributor Author

@ayuwono I believe the issues are due to my incorrect css selector. Please check again.

@ayuwono
Copy link
Contributor

ayuwono commented Jan 21, 2019

Okay, looks good now after your recent commit

aebadirad
aebadirad approved these changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@aebadirad aebadirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jenkins fail is a build fail, subsequent run of this passes. Bringing in.

@aebadirad aebadirad merged commit 927e6c6 into Marklogic-retired:develop Jan 22, 2019
@aebadirad
Copy link
Contributor

@brucean52 can you also create a PR for this to the 4.x line

aebadirad added a commit that referenced this pull request Jan 22, 2019
@aebadirad
Revert "DHFPROD-1428: Improve the usability of text input elements (#…
f08ae79 
…1763)"

This reverts commit 927e6c6.
@aebadirad aebadirad mentioned this pull request Jan 22, 2019
Merged
aebadirad added a commit that referenced this pull request Jan 22, 2019
@aebadirad
Revert "DHFPROD-1428: Improve the usability of text input elements" (#…
da1ba7b 
…1777)

* Revert "DHFPROD-1741 Add a generic Process class (#1765)"

This reverts commit 82b5513.

* Revert "DHFPROD-1428: Improve the usability of text input elements (#1763)"

This reverts commit 927e6c6.
@brucean52 brucean52 deleted the dhfprod-1428 branch January 31, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aebadirad aebadirad aebadirad approved these changes

@wooldridge wooldridge Awaiting requested review from wooldridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brucean52 @ayuwono @aebadirad