Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e/no toaster wait -- comment out waiting for toaster after updating index #1762

Merged
merged 2 commits into from
Jan 19, 2019

Conversation

ayuwono
Copy link
Contributor

@ayuwono ayuwono commented Jan 19, 2019

It seems that with the new npm update to resolve the vulns, the toaster is not recognizable when running e2e with jasmine. This PR will comment out all browser wait on toaster appearance. It will not affect the other tests. Commenting them out, as maybe on the future it could work again.

@ayuwono ayuwono requested a review from aebadirad January 19, 2019 06:13
@aebadirad
Copy link
Contributor

It's weird, but it makes sense.

@aebadirad aebadirad merged commit c1a9ddb into develop Jan 19, 2019
@aebadirad aebadirad deleted the e2e/no-toaster-wait branch January 19, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants