-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm packages for security vulns #1757
Conversation
testing QS |
npm audit report for trace-ui, with your changes, shows 6 remaining vulnerabilities:
|
npm audit report for quick-start, with your changes, shows 0 remaining vulnerabilities:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the trace-ui, it seems you need to make 1 more change:
npm install --save-dev [email protected]
Aside the sec vulns on trace-ui, QS UI e2e is good with this change |
@aebadirad audit is coming back clean and Aries says the UI is working as expected, so I think you're clear to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QS is good after the change
No description provided.