Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing more than one options in input flows using mlcp #1722

Merged
merged 2 commits into from
Dec 29, 2018
Merged

Passing more than one options in input flows using mlcp #1722

merged 2 commits into from
Dec 29, 2018

Conversation

srinathgit
Copy link
Contributor

@srinathgit srinathgit commented Dec 29, 2018 •
edited
Loading

This PR intends to fix marklogic/datahub-central#900 (DHFPROD-1011) , marklogic/datahub-central#758
@aebadirad , let me know if the regex to extract "options=..." is good enough

@srinathgit srinathgit requested a review from aebadirad December 29, 2018 01:45
aebadirad
aebadirad approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@aebadirad aebadirad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I like the addition to our tests for this

@aebadirad aebadirad merged commit f4e2583 into Marklogic-retired:develop Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aebadirad aebadirad aebadirad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srinathgit @aebadirad