Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License? #1

Closed
johanhelsing opened this issue Mar 25, 2023 · 1 comment
Closed

License? #1

johanhelsing opened this issue Mar 25, 2023 · 1 comment

Comments

@johanhelsing
Copy link

We're doing some rigid body xpbd experiments with Bevy and rust. Would be cool to compare notes and implementation.

Currently this project doesn't have a license, though, so I'm a bit reluctant to look too closely at it. Would you mind if we end up using parts of your implementation to compare and fix issues in bevy_xpbd?

Jondolf/avian#2 in particular.

@markeasting
Copy link
Owner

Awesome!

I'm open to help you guys out. I've added an MIT license for this project, since Matthias published his version of PBD.js under that license as well.

My solver has most of the equations from the XPBD paper implemented, but there are a few instances where I had to modify an equation (e.g. negating a result). I've gone over it at least 10 times, and I've added comments for each section as well. I'd say it's around 90% of the way there.

Keep in mind that some of my code uses parts from THREE.js (e.g. AABBs and convex hull generation).

Feel free to look around my codebase and let me know if you have any specific questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants