-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Marionette functions #927
Comments
This would be lovely. I'm using |
Nice, would love to see this go in! |
👍 This reminds me that we need to sort out the filenames, some are camelCased while others are just lowercase. |
I would absolutely love this. I was about to fork and add this in, but checked for discussion first and found this. @jmeas do you plan on making a pull request soon, or should I go ahead and do so? |
@fenduru if you'd like to make the PR go ahead. v2 is still a bit of a ways off, but I'd appreciate the help! |
maybe not so far off 👍 |
I missed the v2 tag in the title. Since this change would not be breaking, could it also be added to master? @jmeas Sounds good. Will hopefully make the PR later today |
Fixed in v2 by #1156 |
There are five Marionette helper functions, and they behave in two different ways. The first type are attached to prototypes, and called directly via
this.someFn
. The other type are left onMarionette
, and are called with the target as the first argument:Marionette.someFn( this, args... )
.It seems the decision was made in PRs like this one to stop passing the target as the first option, and attach the methods directly to the prototypes.
These are the functions and whether or not they're attached to prototypes or not:
✓ normalizeMethods
✓ triggerMethod
✓ extend
✗
getOption(to-be removed in v2)✗ bindEntityEvents
If we want to change
getOption
andbindEntity
to be consistent with the other methods I can make up a PR 👍The text was updated successfully, but these errors were encountered: