Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react typings issue with 15.0.24 #85

Closed
patsissons opened this issue May 5, 2017 · 2 comments
Closed

react typings issue with 15.0.24 #85

patsissons opened this issue May 5, 2017 · 2 comments
Labels
bug

Comments

@patsissons
Copy link
Collaborator

this version introduces some typing for children which seems to break components that have a children typing defined.

// incoming typing change
interface ElementChildrenAttribute { children: {}; }
@patsissons patsissons added the bug label May 5, 2017
@patsissons
Copy link
Collaborator Author

DefinitelyTyped/DefinitelyTyped@13b5f66#diff-5b1e41d6479609ff1a7f33979dcca466

microsoft/TypeScript#13618

@patsissons
Copy link
Collaborator Author

this has been solved by adjusting the typescript npm version identifier to ~2.2.0 which will prevent 2.3.x from being pulled in which is causing the issue. typescript has officially stated that they do not support semver strictly and that breaking changes may occur in minor version bumps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patsissons