Fixes iOS 11 white statusbar issue in Cordova #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS 11 changes the behaviour of how UIWebView and WKWebView calculates the layout. <iOS 11 it would return the layout including the status bar so you could render underneath it. In IOS 11 by default the layout no longer includes the status bar (which is then rendered as white). As the Cordova team has suggested, you can add a viewport tag ```viewport-fit=cover``` to change to the intended behaviour of including the status bar. https://issues.apache.org/jira/browse/CB-12886 However this plugin overrides the viewport tag on load with its own custom value. This corrects the value to also include the fix.
|
Thank you for letting me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS 11 changes the behaviour of how UIWebView and WKWebView calculates the layout.
<iOS 11 it would return the layout including the status bar so you could render underneath it.
In IOS 11 by default the layout no longer includes the status bar (which is then rendered as white).
As the Cordova team has suggested, you can add a viewport tag
viewport-fit=coverto change to the intended behaviour of including the status bar. https://issues.apache.org/jira/browse/CB-12886However this plugin overrides the viewport tag on load with its own custom value. This corrects the value to also include the fix.