Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use naming convention for gdal plugin source files #126

Closed
artemp opened this issue Oct 11, 2011 · 2 comments
Closed

Use naming convention for gdal plugin source files #126

artemp opened this issue Oct 11, 2011 · 2 comments

Comments

@artemp
Copy link
Member

artemp commented Oct 11, 2011

From the dev list:

DataSource is an OGR naming convention whereas Dataset is used for GDAL.

https://lists.berlios.de/pipermail/mapnik-devel/2008-September/000731.html

Consideration should be given to correcting these files to better fit gdal convensions.

@artemp
Copy link
Member Author

artemp commented Oct 11, 2011

[kunitoki] I think we should keep a naming format specific to mapnik datasources, not following the underlying driver implementation naming convention (we will end up mixing too much in all drivers implementation).

If we choose that a '''dataset''' is our source of information, then we should use that in every driver. It is much more straight forward to remember (as i don't have to remember each driver naming convention) and is less error prone (by mixing wrong names in different datasource configuration).

We only need to choose which is the right name for a ''source of mapping informations'' !

@artemp
Copy link
Member Author

artemp commented Oct 11, 2011

[springmeyer] okay, that good reasoning. 'datasource' would conflict with mapnik.Datasource...

So, I guess renaming file-> dataset for both the gdal and ogr driver would be what we should put on the table for consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants