Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to do BUILDTYPE=Release make apackage #1317

Closed
ssuffian opened this issue Jul 5, 2023 · 5 comments
Closed

Unable to do BUILDTYPE=Release make apackage #1317

ssuffian opened this issue Jul 5, 2023 · 5 comments
Labels
android bug Something isn't working build Related to build, configuration or CI/CD

Comments

@ssuffian
Copy link

ssuffian commented Jul 5, 2023

Describe the bug
I am attempting to build the most up to date code from the repo into an AAR file that I can use for an app.

To Reproduce
Steps to reproduce the behavior:

  1. In a terminal, go to 'maplibre-native/platform/android'
  2. Enter BUILDTYPE=Release make apackage
  3. See the following error:
> Task :MapboxGLAndroidSDKTestApp:minifyReleaseWithR8 FAILED
ERROR: Missing classes detected while running R8. Please add the missing classes or apply additional keep rules that are generated in ../maplibre-native/platform/android/MapboxGLAndroidSDKTestApp/build/outputs/mapping/release/missing_rules.txt.
ERROR: R8: Missing class org.bouncycastle.jsse.BCSSLParameters (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 1 other context)
Missing class org.bouncycastle.jsse.BCSSLSocket (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 5 other contexts)
Missing class org.bouncycastle.jsse.provider.BouncyCastleJsseProvider (referenced from: void okhttp3.internal.platform.BouncyCastlePlatform.<init>())
Missing class org.conscrypt.Conscrypt$Version (referenced from: boolean okhttp3.internal.platform.ConscryptPlatform$Companion.atLeastVersion(int, int, int))
Missing class org.conscrypt.Conscrypt (referenced from: boolean okhttp3.internal.platform.ConscryptPlatform$Companion.atLeastVersion(int, int, int) and 4 other contexts)
Missing class org.conscrypt.ConscryptHostnameVerifier (referenced from: okhttp3.internal.platform.ConscryptPlatform$DisabledHostnameVerifier)
Missing class org.openjsse.javax.net.ssl.SSLParameters (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List))
Missing class org.openjsse.javax.net.ssl.SSLSocket (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.configureTlsExtensions(javax.net.ssl.SSLSocket, java.lang.String, java.util.List) and 1 other context)
Missing class org.openjsse.net.ssl.OpenJSSE (referenced from: void okhttp3.internal.platform.OpenJSSEPlatform.<init>())

FAILURE: Build failed with an exception.

It does appear to create an .aar file.

Expected behavior
A successful build.

Screenshots

Platform information (please complete the following information):

  • OS: MacOS
  • Android
  • Main Branch
@ssuffian ssuffian added the bug Something isn't working label Jul 5, 2023
@louwers
Copy link
Collaborator

louwers commented Jul 6, 2023

I am able to reproduce this on Linux.

@louwers louwers added build Related to build, configuration or CI/CD android labels Jul 6, 2023
@louwers
Copy link
Collaborator

louwers commented Jul 6, 2023

I am not sure why the test app is built when creating a release build.

@typebrook The issue seems to be the dependencies that were added as part of #1135. Any chance you can have a look?

@typebrook
Copy link
Collaborator

Hiking now, I'll check this on sunday.

@typebrook
Copy link
Collaborator

@louwers
#1326 should fix this.

I am not sure why the test app is built when creating a release build.

If you think test app should not be built in this case, please open another issue.

@louwers
Copy link
Collaborator

louwers commented Jul 10, 2023

Merged. @ssuffian please try out main and re-open if it is still a problem.

@louwers louwers closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working build Related to build, configuration or CI/CD
Projects
None yet
Development

No branches or pull requests

3 participants