Make all _ fields private

[HarelM]

Motivation

The motivation is to properly define all methods and members of classes with their appropriate modifier (public, private mainly).
This is a big challenge that requires a lot of work.
Having said that, doing it for _ prefixed fields and methods should be relatively simple and an easy win.

[rbrundritt]

I wonder if this would break any workarounds people have implemented in production. In the past I've accessed these via the console to modify things to test and see if it addresses an issue I ran into.

[HarelM]

This is what 2.0 is for...

[drwestco]

Unless the project is using a minifier that mangles private class member names (not common practice), marking members as private shouldn't affect such debug console hacks.

[douglasg14b]

This would break tons of workaround that people use.... I even have some of these kicking around.

[github-actions]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[douglasg14b]

Oh boy, stale bot.

[HarelM]

Unfortunately, due to the large echo system around maplibre I think this won't help anyone but only cause pain.
Having said that, I urge people who are using these private fields to open issues with API request changes/improvements so that they will be able to use fields that they need without the fear of things breaking...