From 04701959b00770cf4f79788104b943dd4e0a4d20 Mon Sep 17 00:00:00 2001
From: Bart Louwers <bart.louwers@gmail.com>
Date: Tue, 15 Oct 2024 13:58:00 +0200
Subject: [PATCH] Fix CMake config

---
 CMakeLists.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 22a3a8a..2269102 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -36,15 +36,16 @@ add_executable(unit-tests ${TEST_SOURCES})
 
 Include(FetchContent)
 
-#https://github.com/catchorg/Catch2/issues/2583
-add_compile_options(-Wno-error=conversion)
-add_compile_options(-Wno-error=sign-conversion)
+# SYSTEM property is not propagated so
+# set this globally ¯\_(ツ)_/¯
+# https://gitlab.kitware.com/cmake/cmake/-/issues/25364
+add_compile_options(-Wno-error)
 
 FetchContent_Declare(
   Catch2
   GIT_REPOSITORY https://github.com/catchorg/Catch2.git
   GIT_TAG        v3.7.1
-  SYSTEM  # https://gitlab.kitware.com/cmake/cmake/-/issues/25364
+  SYSTEM
 )
 FetchContent_MakeAvailable(Catch2)