Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some object types files from older versions don't import correctly? #3472

Closed
YourBuddyBill opened this issue Sep 15, 2022 · 1 comment
Closed
Assignees
Labels
bug Broken behavior.

Comments

@YourBuddyBill
Copy link

YourBuddyBill commented Sep 15, 2022

Describe the bug
Importing an Object (now Class) Types Editor file that worked fine in 1.8.6 only imports the names in 1.9, none of the custom properties themselves appear to be importing correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Create a project
  2. Import the attached object types file
  3. Open Custom Types Editor
  4. Select a custom type
  5. See that there's no properties
  6. Get confused

Expected behavior
I expected the object types to have their custom properties imported as they were defined in the file, and each be individually visible in that big empty space, and for them to then be usable to reference in maps and stuff.

Media
Importing the attached object_types.json file in 1.8.6:
tiled_1_8_6_objecttypes
Importing that same file in 1.9.1:
tiled_1_9_1_customtypes

Here's the file in question (Github doesn't let me upload json files, so rename this file from .txt to .json and try it)
object_types.txt

Specifications:

  • OS: Windows 10
  • Tiled Version: 1.9.1 (worked fine in 1.8.6)
@YourBuddyBill YourBuddyBill added the bug Broken behavior. label Sep 15, 2022
@bjorn
Copy link
Member

bjorn commented Sep 16, 2022

Ah, this isn't really a bug but unfortunately quite bad usability. The JSON format changed in Tiled 1.9, and when importing types, it expects you to select the right file type:

image

Importing of "Object Types JSON" files does not work when you select "Custom Types files" (the default).

I will have a look at auto-detecting the old format in the Import dialog, but I'm afraid the distinction will remain relevant for the Export dialog, since the extension is the same.

@bjorn bjorn closed this as completed in f1fbb82 Sep 16, 2022
@bjorn bjorn self-assigned this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken behavior.
Projects
None yet
Development

No branches or pull requests

2 participants