Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect of undo doesn't always show immediately #1887

Closed
Koopa1018 opened this issue Feb 20, 2018 · 3 comments
Closed

Effect of undo doesn't always show immediately #1887

Koopa1018 opened this issue Feb 20, 2018 · 3 comments
Labels
bug Broken behavior.

Comments

@Koopa1018
Copy link

Koopa1018 commented Feb 20, 2018

In version 1.1.1, when I Undo, it sometimes doesn't show the change immediately. When I press ctrl+Z, nothing seems to happen. This is a purely visual bug--the map gets updated as it should, but it doesn't show a change until I either zoom in (thereby forcing a whole-viewport refresh, I would guess) or manually put the cursor over each and every changed tile.

I'd love to give a little more information, but (un)fortunately, it seems to be a fairly sporadic and/or easy to fix bug--oftentimes, the bug disappears when I try to figure it out (which almost certainly makes this least-concern material, I'd assume), and doesn't resurface even when I restart the program.

I can't think what I might have done to get this to happen, but I will try to figure it out. In the meantime, here's my specs:
OS: Windows 10 Pro x64, version 1709
CPU: Intel i7 3770k
GPU: ATI FirePro v4800, though it also happened when I was using an Intel HD 4000
Tiled version: 1.1.1

@bjorn
Copy link
Member

bjorn commented Feb 20, 2018

Could you try to use the latest development snapshot to see if the problem still persist there? I think it may be fixed there and I am considering to backport that fix to 1.1 for the 1.1.3 release.

@bjorn bjorn added the bug Broken behavior. label Feb 20, 2018
@Koopa1018
Copy link
Author

The glitch hasn't cropped up again, either in the snapshot or in the release. Can't tell if that's because the glitch was fixed, or just because I haven't hit the stimulus that made it happen yet.

Sorry for wasting your time with this. Should've figured out the stimulus before I posted, huh?

@bjorn
Copy link
Member

bjorn commented Mar 6, 2018

Sorry for wasting your time with this. Should've figured out the stimulus before I posted, huh?

No worries, you noticed an issue and that means it's relevant no matter if we are able to find out how to actually reproduce it. I think I've figured out the problem and fixed it in the above commit. See the explanation for a possible reason why you may have not been able to reproduce it anymore. Thanks for the report! :-)

@bjorn bjorn closed this as completed in 49ac684 Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken behavior.
Projects
None yet
Development

No branches or pull requests

2 participants