Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some VT geometries have duplicate rings #52

Closed
mourner opened this issue Aug 20, 2014 · 1 comment
Closed

Some VT geometries have duplicate rings #52

mourner opened this issue Aug 20, 2014 · 1 comment
Labels

Comments

@mourner
Copy link
Member

mourner commented Aug 20, 2014

While investigating shape triangulation for Mapbox GL JS, I discovered a really weird bug: some shapes in VT that are supposed to have one ring of vertices actually return several duplicated rings. I mean, instead of [ring] it has [ring, ring, ring] in the data, where ring is an array of coordinates.

Not sure if it's a Mapnik VT issue, data issue, vector-tile-js or anything else. Any ideas will be appreciated.

One particular example in http://b.tiles.mapbox.com/v4/mapbox.mapbox-streets-v6-dev/15/9370/12535.vector.pbf

The green park around the Embassy of Saudi Arabia in DC is returning 3 rings instead of one.
image

cc @yhahn @springmeyer

@mourner
Copy link
Member Author

mourner commented Aug 20, 2014

I'm sorry, this turned out to be a JS issue on our side.

@mourner mourner closed this as completed Aug 20, 2014
mourner referenced this issue in mapbox/mapbox-gl-js Aug 21, 2014
Rendering performance noticeably improves.
Tesselation is slow though: 100-500ms for the buildings layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant