Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workarounds unsetting map content inset when setting map camera #2248

Closed
1ec5 opened this issue Oct 2, 2019 · 1 comment
Closed
Labels
blocked Blocked by dependency or unclarity. op-ex Refactoring, Tech Debt or any other operational excellence work.

Comments

@1ec5
Copy link
Contributor

1ec5 commented Oct 2, 2019

#2211 worked around mapbox/mapbox-gl-native#15233 by adjusting the map’s content inset instead of its safe area, disabling automaticallyAdjustsScrollViewInsets in route overview mode, and zeroing out the content inset before calling cameraThatFitsShape(_:direction:edgePadding:) or camera(_:fitting:edgePadding:). Once mapbox/mapbox-gl-native#15233 is fixed, these workarounds should be removed so that we can take advantage of the map SDK’s built-in edge padding option distinct from the content inset option.

/ref #2145
/cc @mapbox/navigation-ios @astojilj @fabian-guerra

@1ec5 1ec5 added op-ex Refactoring, Tech Debt or any other operational excellence work. blocked: upstream labels Oct 2, 2019
@zugaldia zugaldia added blocked Blocked by dependency or unclarity. and removed blocked: upstream labels Sep 4, 2020
@1ec5
Copy link
Contributor Author

1ec5 commented Oct 11, 2021

The relevant map SDK APIs have been rewritten as part of map SDK v10.0.0.

@1ec5 1ec5 closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by dependency or unclarity. op-ex Refactoring, Tech Debt or any other operational excellence work.
Projects
None yet
Development

No branches or pull requests

3 participants