You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
When I ported my recent gl-native line breaking changes to gl-js, I found that gl-js has tests for labels with newlines in them (https://github.com/mapbox/mapbox-gl-js/blob/master/test/js/symbol/shaping.test.js). The gl-js tests expect each newline to cause a new line to be created, while gl-native will just treat them like whitespace (so two newlines in the middle of your label will be collapsed down to just one breaking point instead of inserting a blank line).
I'm not sure when we would expect labels to have newlines in them, but we should probably standardize on one behavior or the other.
I'll address this with a port of mapbox/mapbox-gl-js#3743 to gl-native. I have the code ready, but waiting for the first PR to go in before making a new PR to keep the test changes from conflicting.
When I ported my recent gl-native line breaking changes to gl-js, I found that gl-js has tests for labels with newlines in them (https://github.com/mapbox/mapbox-gl-js/blob/master/test/js/symbol/shaping.test.js). The gl-js tests expect each newline to cause a new line to be created, while gl-native will just treat them like whitespace (so two newlines in the middle of your label will be collapsed down to just one breaking point instead of inserting a blank line).
I'm not sure when we would expect labels to have newlines in them, but we should probably standardize on one behavior or the other.
cc @ansis @1ec5
The text was updated successfully, but these errors were encountered: