Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

6.6.0 Build failed with proguard #13088

Closed
klblk opened this issue Oct 12, 2018 · 4 comments
Closed

6.6.0 Build failed with proguard #13088

klblk opened this issue Oct 12, 2018 · 4 comments
Labels
Android Mapbox Maps SDK for Android

Comments

@klblk
Copy link

klblk commented Oct 12, 2018

Steps to reproduce

  1. minifyEnabled true
  2. build

Expected behavior

BUILD SUCCESSFUL

Actual behavior

BUILD FAILED
Log:

Warning: com.mapbox.api.directions.v5.MapboxDirections: can't find referenced class com.sun.xml.internal.ws.spi.db.BindingContextFactory
Warning: com.mapbox.api.directions.v5.MapboxDirections: can't find referenced class com.sun.xml.internal.ws.spi.db.BindingContextFactory
Warning: com.mapbox.api.matching.v5.MapboxMapMatching: can't find referenced class com.sun.xml.internal.ws.spi.db.BindingContextFactory
Warning: com.mapbox.api.matching.v5.MapboxMapMatching: can't find referenced class com.sun.xml.internal.ws.spi.db.BindingContextFactory

Configuration

Android versions: any
Device models: any
Mapbox SDK versions: 6.6.0 (not reproduce on 6.5.0)

@tobrun
Copy link
Member

tobrun commented Oct 12, 2018

@klblk what others Mapbox libraries are you using?
com.mapbox.api. packages aren't packaged in with the maps SDK

@tobrun tobrun added Android Mapbox Maps SDK for Android needs information labels Oct 12, 2018
@klblk
Copy link
Author

klblk commented Oct 12, 2018

i use 'com.mapbox.mapboxsdk:mapbox-sdk-services:4.0.0'. (but not use MapboxDirections api)

Mapbox 6.5.0 build is ok, if change to 6.6.0 build failed (no chage other code )

@tobrun
Copy link
Member

tobrun commented Oct 12, 2018

@klblk the reason why this shows now is that we have slimmed down our proguard configuration on the map sdk to obfuscate more classes for a smaller apk size.

The reason why this isn't handled by the mapbox-sdk-services:4.0.0 dependency, is that itself is not an aar but a jar and doesn't come with a proguard configuration.

You will have to fix this on your end in your app proguard file, as this is not up to the maps sdk to fix and mapbox-sdk-services doesn't support this configuration.

@tobrun
Copy link
Member

tobrun commented Oct 15, 2018

Reopening this issue as we had another report of this. To avoid more users running into this, I will include an entry for Mapbox services in this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

2 participants