Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labels in perspective view #1048

Closed
ansis opened this issue Mar 4, 2015 · 6 comments
Closed

labels in perspective view #1048

ansis opened this issue Mar 4, 2015 · 6 comments

Comments

@ansis
Copy link
Contributor

ansis commented Mar 4, 2015

In the current perspective implementation labels closer to the bottom are bigger and further back labels are smaller. Line labels are rendered skewed.

Why? because it was easier to implement it this way.

It's sort of cool that closer stuff is bigger, bit it also can make labels harder to read. Far labels can be tiny and close ones are giant. The skewness makes reading line labels even harder. The reading difficulty depends on text size and pitch steepness.

  • Should line labels never get skewed? Would straight labels be preferable to curved but skewed labels?
  • Should labels be the same size no matter their vertical position? This would mean that labels would show up and disappear as you pan. See apple maps for how this would look.

Example with altitude=1 pitch=50. This might be a bit more extreme than usual.
screen shot 2015-03-03 at 7 17 45 pm

@ansis ansis added the tilt :O label Mar 4, 2015
@peterqliu
Copy link
Contributor

Should line labels never get skewed?

I think tilt mode is used to emphasize the on-the-ground perspective, and inherently favors nearby things over faraway things. Toward this end, I think the skew is actually good because it affects nearby objects the least, thereby establishing this hierarchy of readability from near > far.

@mourner
Copy link
Member

mourner commented Mar 4, 2015

I also think the way it works in the current perspective branch is perfectly fine for now. Lets not worry about skewed labels readability until we solve higher priority issues.

Would straight labels be preferable to curved but skewed labels?

No, it would be worse in my opinion.

@ansis
Copy link
Contributor Author

ansis commented Mar 11, 2015

Nothing actionable here right now. closing

@ansis ansis closed this as completed Mar 11, 2015
@bsudekum
Copy link

bsudekum commented Oct 1, 2015

@ansis I think we should revisit this issue and what a perspective-quest-round-two would look like. Two large issues I'm seeing with perspective:

  1. Line labels should be rendered similar to POI labels. I.E. no skewing
  2. Labels in the background are illegible.
    • I think this will be fixed if 1 is fixed first. Even line labels near the middle of the screen are difficult to read.

@bsudekum bsudekum reopened this Oct 1, 2015
@nickidlugash
Copy link

Line labels should be rendered similar to POI labels. I.E. no skewing

👍

@lucaswoj
Copy link
Contributor

We are making this behaviour configurable with *-pitch-alignment and *-rotation-alighment per mapbox/mapbox-gl-style-spec#459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants