Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider namespacing all css #248

Closed
samanpwbb opened this issue Apr 9, 2019 · 0 comments · Fixed by #249
Closed

consider namespacing all css #248

samanpwbb opened this issue Apr 9, 2019 · 0 comments · Fixed by #249

Comments

@samanpwbb
Copy link
Contributor

Most css rules begin with mapboxgl-ctrl-geocoder in this project, but css is not comprehensively namespaced. There are a few css rules like geocoder-collapsed and geocoder-icon that run the risk of colliding with other names in the global css scope. There are two ways to namespace the css. Either by prefixing all classnames with a shared substring (so .mapboxgl-ctrl-geocoder--geocoder-icon) or by adding specificity (.mapboxgl-ctrl-geocoder .geocoder-icon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant