Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geocoder x is not quite centered #241

Closed
samanpwbb opened this issue Apr 6, 2019 · 2 comments · Fixed by #249
Closed

geocoder x is not quite centered #241

samanpwbb opened this issue Apr 6, 2019 · 2 comments · Fixed by #249
Assignees
@katydecorah

Comments

@samanpwbb
Copy link
Contributor

samanpwbb commented Apr 6, 2019 •
edited
Loading

looks like the x is a couple pixels too low:

Screen Shot 2019-04-05 at 6 06 45 PM

I'm using the geocoder with collapsed: true if that makes a difference. Flex box centering would be the right tool for the job here.
@katydecorah
Copy link
Contributor

@samanpwbb I'm not having luck recreating this, unfortunately. Do you have a reduced test case handy?

@katydecorah
Copy link
Contributor

In Saman's example Assembly's button reset is causing the misalignment. Looks like we'll need to clear out the font and line-height on .mapboxgl-ctrl-geocoder button to prevent the icon position from being changed by other libraries/resets

@katydecorah katydecorah self-assigned this Apr 9, 2019
@katydecorah katydecorah mentioned this issue Apr 9, 2019
Merged
2 tasks
@samanpwbb samanpwbb mentioned this issue Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katydecorah katydecorah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

css fixes: close button, namespace css, collapse width mapbox/mapbox-gl-geocoder
2 participants
@samanpwbb @katydecorah