Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create performance benchmarks #243

Closed
lucaswoj opened this issue Feb 24, 2016 · 3 comments · Fixed by #258
Closed

Create performance benchmarks #243

lucaswoj opened this issue Feb 24, 2016 · 3 comments · Fixed by #258
Milestone

Comments

@lucaswoj
Copy link

We should create some performance benchmarks for mapbox-gl-draw that are quantifiable and repeatable.

Ideally, these benchmarks would be runnable in a headless environment using something like http://karma-runner.github.io.

It probably makes sense to work on the upstream mapbox-gl-js performance benchmarks first, and use the lessons and infrastructure from those to build the mapbox-gl-draw benchmarks.

ref mapbox/mapbox-gl-js#954
ref mapbox/mapbox-gl-js#1362

@mcwhittemore
Copy link
Contributor

Like tests, should these use mapbox-gl-js or mapbox-gl-js-mock? Using a mock would let us know the perf of gl-draw. Using the real thing, would help us catch when gl-draw is using a slow gl-js function.

@lucaswoj
Copy link
Author

The performance tests should use the real mapbox-gl-js.

@lucaswoj
Copy link
Author

Highly relevant stuff moving in mapbox/mapbox-gl-js#2231

@mcwhittemore mcwhittemore modified the milestone: Fresh Start Mar 25, 2016
@mcwhittemore mcwhittemore mentioned this issue Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants