Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every url in discovery document has to start with the issuer url - but why? #419

Closed
rbkrabbe opened this issue Sep 5, 2018 · 4 comments
Closed

Comments

@rbkrabbe
Copy link

rbkrabbe commented Sep 5, 2018

When using strictDiscoveryDocumentValidation (the default), all urls in the discovery document must start with the issuer url, but this does not seem to be a part of any OAuth, or OpenID specification that I can find. Why is this a requirement? It is incompatible wth eg. Googles OpenID configuration: https://accounts.google.com/.well-known/openid-configuration.

@jaco-terbraak
Copy link

It's also incompatible with WSO2-IS.

@jeroenheijmans
Copy link
Collaborator

Based on what I know about the library, and digging through the commits that introduced that option, I would say that it's a little overzealous and you can safely set the strictDiscoveryDocumentValidation option to false for Google OpenID and WSO2-IS, and move on.

Assuming I'm right, we could leave this GH issue open as a request to add this note (that it can be safely set to false for some IDServers) to the property's documentation. But that's probably something only the original author / maintainer can answer for us.

@manfredsteyer
Copy link
Owner

Yes, you are right. You can deactivate it and it isn't demanded by the specs. It's more or less a best practice as it prevents a specific attack where someone manages to fake a discovery document.

@cconcannon
Copy link

The discovery document for PingOne relying parties also fails the validation check, and as such requires setting strictDiscoveryDocumentValidation = false;

I'm opening a PR to reflect this configuration in the "Getting Started" section, as it seems relevant enough to multiple ID Providers and it took a little bit of digging to find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants