Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DEVp2p handshake and other messages #166

Open
germsvel opened this issue Jun 14, 2018 · 3 comments
Open

Handle DEVp2p handshake and other messages #166

germsvel opened this issue Jun 14, 2018 · 3 comments

Comments

@germsvel
Copy link
Contributor

Currently, our ExWire tcp connection is handling the encrypted handshake.

We now need to be able to handle a DEVp2p handshake (Hello messages) as well as Disconnect, Ping, and Pong messages. All of these messages should only be send/received if the crypto handshake was successful.

For more on DEVp2p protocol, see https://github.com/ethereum/wiki/wiki/%C3%90%CE%9EVp2p-Wire-Protocol

Note that all messages must be framed. For more on framing see https://github.com/ethereum/devp2p/blob/master/rlpx.md#framing.

@hayesgm
Copy link
Contributor

hayesgm commented Oct 29, 2018

Was this closed by #410?

@InoMurko
Copy link
Member

InoMurko commented Dec 3, 2018

Can we close this @hayesgm ?

@germsvel
Copy link
Contributor Author

germsvel commented Dec 4, 2018

Yeah, I think #410 may have handled this. I'm not sure how robust it is, but it seems like this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants