Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OriginGrid plugin: Sync with Render event. #473

Merged
merged 3 commits into from
Oct 7, 2021
Merged

OriginGrid plugin: Sync with Render event. #473

merged 3 commits into from
Oct 7, 2021

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Oct 6, 2021 •
edited
Loading

part of #466
resolves #469
image

@francocipollone francocipollone mentioned this pull request Oct 6, 2021
Closed
@francocipollone francocipollone force-pushed the francocipollone/origin_display_fix_crash branch from 3ff40f9 to ae0d88b Compare October 6, 2021 20:56
@francocipollone
Copy link
Collaborator Author

francocipollone commented Oct 6, 2021 •
edited
Loading

Given that the initialization process I made for OriginDisplay worked correctly I went ahead and I simplified the initialization process I did in #471 for MaliputViewerPlugin. See 407cdb9

agalbachicar
agalbachicar previously approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone
Copy link
Collaborator Author

This PR also resolves #469
The cause was the same.

agalbachicar
agalbachicar approved these changes Oct 7, 2021
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit 973c213 into main Oct 7, 2021
@francocipollone francocipollone deleted the francocipollone/origin_display_fix_crash branch October 7, 2021 19:01
@francocipollone francocipollone linked an issue Oct 7, 2021 that may be closed by this pull request
maliput_viewer: Crash when hovering or selecting lanes #466
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@francocipollone @agalbachicar