MaliputViewerPlugin: Improve initialization to fix crash. #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've solved the issue with the visualization. Again, the key was to sync the scene set up with the render event. @agalbachicar It is ready to review. I can't be happier. EDIT: sudo sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-stable `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-stable.list'
wget http://packages.osrfoundation.org/gazebo.key -O - | sudo apt-key add -
sudo apt-get update
sudo apt-get install -y libignition-gui3-dev libignition-rendering3-dev libignition-transport8-dev libignition-msgs5-dev libignition-common3-dev libignition-math6-dev
sudo apt-get upgradeAlso, deactivate the |
agalbachicar
requested changes
Oct 6, 2021
delphyne_gui/visualizer/maliput_viewer_plugin/maliput_viewer_plugin.cc
Outdated
Show resolved
Hide resolved
delphyne_gui/visualizer/maliput_viewer_plugin/maliput_viewer_plugin.cc
Outdated
Show resolved
Hide resolved
delphyne_gui/visualizer/maliput_viewer_plugin/maliput_viewer_plugin.cc
Outdated
Show resolved
Hide resolved
delphyne_gui/visualizer/maliput_viewer_plugin/maliput_viewer_plugin.cc
Outdated
Show resolved
Hide resolved
delphyne_gui/visualizer/maliput_viewer_plugin/maliput_viewer_plugin.cc
Outdated
Show resolved
Hide resolved
delphyne_gui/visualizer/maliput_viewer_plugin/maliput_viewer_plugin.hh
Outdated
Show resolved
Hide resolved
agalbachicar
reviewed
Oct 6, 2021
| void Initialize(); | ||
|
|
||
| /// \brief Set up the scene modifying the light and instanciating the ArrowMesh, Selector and TrafficLightManager. |
| @@ -420,7 +423,7 @@ class MaliputViewerPlugin : public ignition::gui::Plugin { | |||
| std::atomic<bool> newRoadNetwork{false}; | |||
|
|
|||
| /// \brief Indicates the scene needs to be set-up. | |||
| bool setUpScene = false; | |||
| std::atomic<bool> setUpScene = false; | |||
There was a problem hiding this comment.
Nit: use braced initialization as with the others.
There was a problem hiding this comment.
Ops, sorry for that. Done.
agalbachicar
previously approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #466
This PR
For a reason that I couldn't identify yet, the initialization process that we were performing wasn't correct and that causes that crash later on. I improved the initialization process and the crash is no longer present.
Note: To test the lane selection in focal I manually updated ign-gui using apt as we need the changes in 3.6 version. (See #452 (comment))
First approach:
At first I thought it was related to a lack of syncing between render thread and our changes in the scene but the way we were doing it was the recommended(hooking to the Render event)
Known issue
Sometimes when hitting the Load button the meshes aren't visualized correctly however when pressing on the scene you can still select the lanes. This is the reason this pr is still draft
