Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainsail making chrome extremely slow and break other website rendering (youtube especially) #1229

Closed
akhamar opened this issue Jan 15, 2023 · 14 comments · Fixed by #1232
Closed
Labels

Comments

@akhamar
Copy link

akhamar commented Jan 15, 2023

Mainsail Version:

2.4.1

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

Since the last few update (since 2.4.1 ?) I had strong slow down on other web page (especially Youtube video playing).
Having mainsail open (background or foreground in tabs) make the whole chrome to be slow and having problem rendering other website.

What did you expect to happen instead?

Not having other website in separate tabs having rendering issues.

How to reproduce this bug?

Reproduce is extremely easy.
Open youtube and watch a video (4K), see that video is rendering correctly. Now open mainsail in a separate tab, and see that youtube start stuttering, video feed break, etc.

Additional information:

No response

@akhamar akhamar added the ⚡ Type: Bug Something isn't working label Jan 15, 2023
@akhamar
Copy link
Author

akhamar commented Jan 15, 2023

I'll add that this problem only appear when on the dashboard of mainsail.
Chrome Version 108.0.5359.126

My dashboard layout :
image

@akhamar
Copy link
Author

akhamar commented Jan 15, 2023

I've narrowed down on the dashboard what's causing the issue :

  • temperatures
  • miscellaneous

Closing down those two panel make the problem goes "away".

@meteyou
Copy link
Member

meteyou commented Jan 15, 2023

The tempchart needs a lot of performance. this is not a bug. It just needs this performance to render it. feel free to disable the tempchart if you don't like it.

@meteyou meteyou closed this as completed Jan 15, 2023
@akhamar
Copy link
Author

akhamar commented Jan 15, 2023

I wasn't getting this problem from previous version of mainsail.
And if just a single page break the whole browser it's definitely a bug.

@meteyou
Copy link
Member

meteyou commented Jan 15, 2023

the tempchart is only on the dashboard. if you open another page it will unmount this component and it dont need any performace. feel free to check the changelog. there is no difference in this area in the newer releases.

@akhamar
Copy link
Author

akhamar commented Jan 15, 2023

After further research it's the moving icons posing problems

image

@meteyou
Copy link
Member

meteyou commented Jan 15, 2023

i think these icons moving since v0.3.0...

@akhamar
Copy link
Author

akhamar commented Jan 15, 2023

Maybe a chrome update made them behave incorrectly. Or the way of making them move since an old version wasn't really the way to do it. Dunno.

@meteyou meteyou reopened this Jan 15, 2023
@meteyou
Copy link
Member

meteyou commented Jan 15, 2023

I cannot reproduce an issue with a youtube 4k video, but I see a difference in the chrome task manager.

@akhamar
Copy link
Author

akhamar commented Jan 15, 2023

I think it's also due to chrome bringing some bug or change. I've seen that other website with animation (rotation and such) have the same kind of behavior.
Might be a good idea to look at chrome issue regarding this situation.

Also rather than just removing the animation, make it so we can chose between animated or not maybe ?

@meteyou
Copy link
Member

meteyou commented Jan 15, 2023

It would also be possible, but I don't see any benefit for this little "function"/"Gucci stuff".

I will double check it in other browsers to be sure it is only a chrome bug or a general performance issue.

@akhamar
Copy link
Author

akhamar commented Jan 16, 2023

As you said the rotating animation was already present since a "long time ago". I would concur that a recent chrome update somehow killed the perf of this particular kind of html/css transformation.
It is possible that all browser using chrome engine will surfer the same problem.

@dw-0
Copy link
Member

dw-0 commented Jan 29, 2023

im unable to reproduce the issue on chrome 108.0.5359.125. i had 3 spinning fan icons on the dashboard AND the temperature chart, while watching this video in 4k: https://www.youtube.com/watch?v=z24WRrAmdwc

I don't even see a high cpu load in the chrome task manager while mainsail running in the background (on the dashboard) and the video running in the foreground. no stuttering of the video at all and the cpu load of the mainsail tab rarely just spikes from 0% to 1.5%.

i see that your chrome version is exactly 1 off compared to mine. i will update my chrome and test again.

edit:
so i have updated my chrome to version 109.0.5414.120 and saw some differences, but not in a way that im able to reproduce the issue. while having mainsail on the dashboard in a background tab (just like before) and watching the video, i now see the following. cpu of the mainsail tab switches between 0% and 1.5% with regular "spikes" to 3%. whats new is, that there are very rarely spikes to around 25%. but those are very irregular and still don't cause the playing video to stutter at all.

you said your pc is a 32core cpu with 64gb of ram, so your pc has a lot more power than mine. i would expect the issue to occur on my pc (4 core, 16gb). so the only conclusion i can draw for now is, that there is something wrong with your system. i have no idea what and why, but if there would be severe performance issues i think we would have seen a lot more reports by now.
you don't have a webcam running, have you?

@LimesKey
Copy link

LimesKey commented Apr 5, 2023

I am receiving this issue too, both with Chrome and FireFox, more prominently with Firefox. It seems to be caused by the webcam and somewhat by the temperature tab. With the webcam tab open, the tab consumes 2GB of RAM and 100% of my CPU on my laptop. The webcam is 1080p 30FPS. The webcam tab also tends to be very slow to refresh, even though it reports to be 30fps, the image is only being refreshed every few seconds. As you can see in the photos it shows the resources the tab consumes and that the webcam tab is greyed out as it usually takes 10 - 20 seconds to load.

image
image
It seems to be a memory leak, maybe from caching every frame of the webcam? The browser tab hits 6GB of memory usage from only being on the page for 15 minutes.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants