Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature input font size too small #1038

Closed
mikhailbot opened this issue Aug 20, 2022 · 5 comments · Fixed by #1107
Closed

Temperature input font size too small #1038

mikhailbot opened this issue Aug 20, 2022 · 5 comments · Fixed by #1107
Labels
Is: UI/UX Anything referencing UI/UX ⚡ Type: Bug Something isn't working
Milestone

Comments

@mikhailbot
Copy link

mikhailbot commented Aug 20, 2022

Mainsail Version:

v2.2.1

Browser:

Safari

Device:

Mobile device (Phone, Tablet or similar)

Operating System:

iOS

What happened?

In Safari on iOS font sizes smaller than 16px cause the browser to zoom in. Often times this causes the interface to gain a horizontal scroll causing alignment and usability issues.

What did you expect to happen instead?

No zooming in, keeping viewport consistent.

How to reproduce this bug?

Visit the web ui on iOS with Safari and edit one of the temperature inputs.

Additional information:

No response

@mikhailbot mikhailbot added the ⚡ Type: Bug Something isn't working label Aug 20, 2022
@meteyou
Copy link
Member

meteyou commented Aug 23, 2022

pls post a screenshot

@meteyou meteyou added the ❔ User Input Further information is requested label Aug 23, 2022
@mikhailbot
Copy link
Author

MainsailInputZoom

See attached. It's not major but it is common practise to not have input fields smaller than 16px to prevent the zoom-in by Safari on iOS (which then adds horizontal scrolling requiring you to zoom out but not too far or you go into tab switching mode or reloading the page).

Of note I've another install on 2.1.2 without the smaller font size.

@meteyou
Copy link
Member

meteyou commented Aug 23, 2022

do you use a theme or something else? it cannot be only in one installation an issue...

@mikhailbot
Copy link
Author

Nope, plain iOS and plain MainsailOS install and for reference it's this CSS too.

https://github.com/mainsail-crew/mainsail/blob/develop/src/components/inputs/TemperatureInput.vue#L3

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Ahoi!

It looks like there hasn't been any recent updates on
this issue. If you created this issue and no longer
consider it to get merged, then please login to github
and close it. Otherwise, if there is no further activity
on this issue, it will be automatically closedwithin the
next 7 days.

Fair wind and a following sea!
~ Your friendly MainsailGithubBot

PS: I'm just an automated script, not a real sailor.

@dw-0 dw-0 added this to the v2.4.0 milestone Sep 9, 2022
@dw-0 dw-0 added Is: UI/UX Anything referencing UI/UX and removed ❔ User Input Further information is requested 💤 Stale labels Sep 9, 2022
@dw-0 dw-0 closed this as completed in #1107 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Is: UI/UX Anything referencing UI/UX ⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants