Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie store session always expires after cookie Expiration Time even with user activities #1134

Closed
msalahz opened this issue Dec 14, 2016 · 5 comments
Assignees
Milestone

Comments

@msalahz
Copy link
Contributor

msalahz commented Dec 14, 2016

I'm using ember simple auth using cookie store and session always expires after cookie Expiration Time even with user activities. Is this is the default behavior ? Shouldn't we renew session expiration if user is not idle

Ember 2.9.1
Ember Data 2.10.0
Ember Simple Auth 1.1.0

@stevenwu
Copy link
Collaborator

@msalahz what is your cookie expiration time?

@msalahz
Copy link
Contributor Author

msalahz commented Dec 24, 2016

@stevenwu I tried 30 sec and 1 min to test but it always expires when I have browser tab opened

@marcoow
Copy link
Member

marcoow commented Dec 26, 2016

The absolute cookie expiration time is only extended every 60 seconds. If the configured expiration time is below that the cookie will actually expire before it can be extended. Please try an expiration time of 90 seconds or so. There should certainly be a warning when an expiration setting that's below the extension interval is detected.

Also, what's your motivation for such a short expiration?

@msalahz
Copy link
Contributor Author

msalahz commented Dec 30, 2016

I was just making a quick testing @marcoow, and I didn't know about extended period. I tested this with 90 sec and it's working fine Thank you!

@msalahz msalahz closed this as completed Dec 30, 2016
@marcoow
Copy link
Member

marcoow commented Jan 2, 2017

Reopening this as we should have a warning logged when we detect the expiration is below the renewal interval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants