Add minimum required face version in setup.py #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 20.7.0 `glom` requires at least version 20.1.0 of `face`, as that's the version of `face` where `face.helpers.get_wrap_width` got added. This commit adds the version 20.1.0 of `face` to the required dependencies in `setup.py`, to avoid incompatbilities with environments which provide older versions of `face`.
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 26 26
Lines 4030 4030
Branches 575 575
=======================================
Hits 3985 3985
Misses 21 21
Partials 24 24 Continue to review full report at Codecov.
|
|
Great point, good catch, nice fix, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 20.7.0
glomrequires at least version 20.1.0 offace,as that's the version of
facewhereface.helpers.get_wrap_widthgotadded. This commit adds the version 20.1.0 of
faceto the requireddependencies in
setup.py, to avoid incompatbilities with environmentswhich provide older versions of
face.