From 7027691ddc1ebe0f8ae61d3c6ecefae563c225f1 Mon Sep 17 00:00:00 2001 From: Marcel Hauri Date: Thu, 14 Jun 2018 15:36:33 +0200 Subject: [PATCH 1/3] Method Magento\Webapi\Model\Soap\Fault::toXml() invoked with 1 parameter, 0 required. --- app/code/Magento/Webapi/Test/Unit/Model/Soap/FaultTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Webapi/Test/Unit/Model/Soap/FaultTest.php b/app/code/Magento/Webapi/Test/Unit/Model/Soap/FaultTest.php index 1ac7943fa6484..8d4cd8561520c 100644 --- a/app/code/Magento/Webapi/Test/Unit/Model/Soap/FaultTest.php +++ b/app/code/Magento/Webapi/Test/Unit/Model/Soap/FaultTest.php @@ -125,7 +125,7 @@ public function testToXmlDeveloperModeOff() public function testToXmlDeveloperModeOn() { $this->_appStateMock->expects($this->any())->method('getMode')->will($this->returnValue('developer')); - $actualXml = $this->_soapFault->toXml(true); + $actualXml = $this->_soapFault->toXml(); $this->assertContains('', $actualXml, 'Exception trace is not found in XML.'); } From 6e70ebd7c0183f113ffbc261f149739641f216a0 Mon Sep 17 00:00:00 2001 From: Marcel Hauri Date: Thu, 14 Jun 2018 15:38:23 +0200 Subject: [PATCH 2/3] type hints and incorrect case in class reference --- app/code/Magento/Webapi/Controller/Soap/Request/Handler.php | 2 +- app/code/Magento/Webapi/Model/Plugin/GuestAuthorization.php | 2 +- app/code/Magento/Webapi/Model/Soap/Server.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/code/Magento/Webapi/Controller/Soap/Request/Handler.php b/app/code/Magento/Webapi/Controller/Soap/Request/Handler.php index 081b4c829475a..0f1fad523e8f5 100644 --- a/app/code/Magento/Webapi/Controller/Soap/Request/Handler.php +++ b/app/code/Magento/Webapi/Controller/Soap/Request/Handler.php @@ -113,7 +113,7 @@ public function __construct( * * @param string $operation * @param array $arguments - * @return \stdClass|null + * @return array * @throws WebapiException * @throws \LogicException * @throws AuthorizationException diff --git a/app/code/Magento/Webapi/Model/Plugin/GuestAuthorization.php b/app/code/Magento/Webapi/Model/Plugin/GuestAuthorization.php index 4eb8b131e0718..78082fab8bd9c 100644 --- a/app/code/Magento/Webapi/Model/Plugin/GuestAuthorization.php +++ b/app/code/Magento/Webapi/Model/Plugin/GuestAuthorization.php @@ -19,7 +19,7 @@ class GuestAuthorization * Check if resource for which access is needed has anonymous permissions defined in webapi config. * * @param \Magento\Framework\Authorization $subject - * @param callable $proceed + * @param \Closure $proceed * @param string $resource * @param string $privilege * @return bool true If resource permission is anonymous, diff --git a/app/code/Magento/Webapi/Model/Soap/Server.php b/app/code/Magento/Webapi/Model/Soap/Server.php index aa7a4041ae415..be2dec2860772 100644 --- a/app/code/Magento/Webapi/Model/Soap/Server.php +++ b/app/code/Magento/Webapi/Model/Soap/Server.php @@ -31,7 +31,7 @@ class Server const REQUEST_PARAM_LIST_WSDL = 'wsdl_list'; /** - * @var \Magento\Framework\App\AreaLIst + * @var \Magento\Framework\App\AreaList */ protected $_areaList; From 73abec6f7601f3e7753e4b5a378d53ca7073b526 Mon Sep 17 00:00:00 2001 From: Marcel Hauri Date: Thu, 14 Jun 2018 15:39:12 +0200 Subject: [PATCH 3/3] Access to an undefined property Magento\Webapi\Controller\Soap::$_appState --- app/code/Magento/Webapi/Controller/Soap.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/code/Magento/Webapi/Controller/Soap.php b/app/code/Magento/Webapi/Controller/Soap.php index 32e1cdb9c888d..215ae4752aa1d 100644 --- a/app/code/Magento/Webapi/Controller/Soap.php +++ b/app/code/Magento/Webapi/Controller/Soap.php @@ -51,6 +51,11 @@ class Soap implements \Magento\Framework\App\FrontControllerInterface */ protected $_errorProcessor; + /** + * @var \Magento\Framework\App\State + */ + protected $_appState; + /** * @var \Magento\Framework\Locale\ResolverInterface */