Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactional Email logo not updating #9991

Closed
noprobz09 opened this issue Jun 20, 2017 · 7 comments
Closed

Transactional Email logo not updating #9991

noprobz09 opened this issue Jun 20, 2017 · 7 comments
Labels
bug report Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@noprobz09
Copy link

noprobz09 commented Jun 20, 2017

Preconditions

Magento 2.1.3
PHP version 7.0.8
MySQL version 5.7.13

Steps to reproduce

Transactional Email
To update Email logo

Expected result

The updated email logo will show

Actual result

updated email logo not showing

Screenshots:
https://www.screencast.com/t/i6AHj951YidQ

@hostep
Copy link
Contributor

hostep commented Jun 20, 2017

@noprobz09: this has been reported at least 10 times before, please try searching for existing issues before creating a new one, tnx :)

Anyway, the issue was already fixed on the develop branch and was backported to the 2.1-develop branch and will most likely be released in the next 2.1.x release.
See #5352 for more details.

@korostii
Copy link
Contributor

this has been reported at least 10 times before

Well, to be perfectly honest, fix ( 23103c0 ) was done more than a year(sic!) ago and yet it's still not available in the latest released version. So whose fault is that?

I wouldn't blame users for reporting it 10 times more.
It's not as if there's an easy workaround available for everyone (like, for example, "update to 2.1.7")

@hostep
Copy link
Contributor

hostep commented Jun 20, 2017

@korostii: chill chill, instead of whining everywhere about issues not being fixed in a new release, you could be a lot more helpful by creating backports of fixes yourself like I am doing. It seems to be the only way to quickly make Magento more stable then the state it is in today.
I agree with you that it should be Magento's responsibility to backport these fixes, but it seems that they are too busy with all kinds of other stuff (creating new features for the Enterprise Edition or something like that, who knows). If we take matters into our own hand it will go much quicker :)

@korostii
Copy link
Contributor

korostii commented Jun 20, 2017

@hostep: There is this bottleneck called "Community Engineering Team". It seems that both backporting and processing Pull Requests falls under their jurisdiction and the team is quite small.

As far as I understand, they decided to focus on Pull requests precisely because backporting everything would take too much effort: there were dozend if not hundreds of fixes missing from 2.1 and only present on develop. Thus it was decided to backport the top-voted issues only. When that failed, they switched to PRs as a way to prioritize backporting.

So please keep that in mind: that's still just a fast line for fixes which you really really need ASAP, like that tinyMCE fix you pushed through (great job, by the way!).

IMHO the pull requests add much more overhead onto Magento's devs than backporting itself would.
Seeing pull requests section flooded with these backports makes me sad.
I'd rather see one major improvement like #9367 processed by Magento.

other stuff (creating new features for the Enterprise Edition or something like that, who knows)

My guess would be "preparing 2.2 for the alpha release", actually. In any case, it's quite annoying.

I am sorry if my comments bother you, but I feel it's necessary to remind the guys at Magento that there's a lot of people awaiting those fixes. I just hope eventually Magento manages to improve the bugfixing pace, because it's the responsible thing to do. Besides, it does them much good in PR terms, even if it costs a couple more people attached to the job.

@andidhouse
Copy link

i think this is about 10 minutes to fix for a magento core team member - instead it is reported here at least 10 times and hundreds of people spend hours on this topic.

I really do not like how magento handles obvious simple bugs - this is far from professional in my point of view.

@maurice-j
Copy link

Dirty Fix: v2.1.7
The email image you upload goes to:
pub/media/logo/stores/1/yourlogo.jpg
Magento is looking for (and links to)
pub/media/email/logo/stores/1/yourlogo.jpg

I manually created the pub/media/email/logo/stores/ structure on our server and added the images files myself. They now link correctly and the email contain the correct logo.

@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Sep 29, 2017
@magento-engcom-team
Copy link
Contributor

@noprobz09, thank you for your report.
We were not able to reproduce this issue by following the steps you provided. If you'd like to update it, please reopen the issue.
We tested the issue on 2.3.0, 2.2.0, 2.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

7 participants