-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transactional Email logo not updating #9991
Comments
@noprobz09: this has been reported at least 10 times before, please try searching for existing issues before creating a new one, tnx :) Anyway, the issue was already fixed on the develop branch and was backported to the 2.1-develop branch and will most likely be released in the next 2.1.x release. |
Well, to be perfectly honest, fix ( 23103c0 ) was done more than a year(sic!) ago and yet it's still not available in the latest released version. So whose fault is that? I wouldn't blame users for reporting it 10 times more. |
@korostii: chill chill, instead of whining everywhere about issues not being fixed in a new release, you could be a lot more helpful by creating backports of fixes yourself like I am doing. It seems to be the only way to quickly make Magento more stable then the state it is in today. |
@hostep: There is this bottleneck called "Community Engineering Team". It seems that both backporting and processing Pull Requests falls under their jurisdiction and the team is quite small. As far as I understand, they decided to focus on Pull requests precisely because backporting everything would take too much effort: there were dozend if not hundreds of fixes missing from 2.1 and only present on develop. Thus it was decided to backport the top-voted issues only. When that failed, they switched to PRs as a way to prioritize backporting. So please keep that in mind: that's still just a fast line for fixes which you really really need ASAP, like that tinyMCE fix you pushed through (great job, by the way!). IMHO the pull requests add much more overhead onto Magento's devs than backporting itself would.
My guess would be "preparing 2.2 for the alpha release", actually. In any case, it's quite annoying. I am sorry if my comments bother you, but I feel it's necessary to remind the guys at Magento that there's a lot of people awaiting those fixes. I just hope eventually Magento manages to improve the bugfixing pace, because it's the responsible thing to do. Besides, it does them much good in PR terms, even if it costs a couple more people attached to the job. |
i think this is about 10 minutes to fix for a magento core team member - instead it is reported here at least 10 times and hundreds of people spend hours on this topic. I really do not like how magento handles obvious simple bugs - this is far from professional in my point of view. |
Dirty Fix: v2.1.7 I manually created the pub/media/email/logo/stores/ structure on our server and added the images files myself. They now link correctly and the email contain the correct logo. |
@noprobz09, thank you for your report. |
Preconditions
Magento 2.1.3
PHP version 7.0.8
MySQL version 5.7.13
Steps to reproduce
Transactional Email
To update Email logo
Expected result
The updated email logo will show
Actual result
updated email logo not showing
Screenshots:
https://www.screencast.com/t/i6AHj951YidQ
The text was updated successfully, but these errors were encountered: